linux-kernel - Re: [PATCH] alpha: fix build breakage in asm/cacheflush.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimsf03FvWeTV0mC=dX7vsH=6yihiXa5MH_raAw+@mail.gmail.com>
Date:	Sun, 19 Sep 2010 00:52:19 -0400
From:	Matt Turner <mattst88@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	linux-alpha@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alpha: fix build breakage in asm/cacheflush.h

On Tue, Sep 14, 2010 at 5:00 AM, Tejun Heo <tj@...nel.org> wrote:
> Alpha SMP flush_icache_user_range() is implemented as an inline
> function inside include/asm/cacheflush.h.  It dereferences @current
> but doesn't include linux/sched.h and thus causes build failure if
> linux/sched.h wasn't included previously.  Fix it by including the
> needed header file explicitly.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  arch/alpha/include/asm/cacheflush.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h
> index 01d71e1..012f124 100644
> --- a/arch/alpha/include/asm/cacheflush.h
> +++ b/arch/alpha/include/asm/cacheflush.h
> @@ -43,6 +43,8 @@ extern void smp_imb(void);
>  /* ??? Ought to use this in arch/alpha/kernel/signal.c too.  */
>
>  #ifndef CONFIG_SMP
> +#include <linux/sched.h>
> +
>  extern void __load_new_mm_context(struct mm_struct *);
>  static inline void
>  flush_icache_user_range(struct vm_area_struct *vma, struct page *page,

Thanks! Applied this to my tree and sent it to Linus.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/