linux-kernel - Re: [PATCH 0/17]: New SCSI target framework (SCST) with dev handlers and 2 target drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 19 Sep 2010 11:54:37 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Vladislav Bolkhovitin <vst@...b.net>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	scst-devel <scst-devel@...ts.sourceforge.net>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Christie <michaelc@...wisc.edu>,
	Jeff Garzik <jeff@...zik.org>, Vu Pham <vuhuong@...lanox.com>,
	James Smart <James.Smart@...lex.com>,
	Joe Eykholt <jeykholt@...co.com>, Andy Yan <ayan@...vell.com>,
	Chetan Loke <generationgnu@...oo.com>,
	Hannes Reinecke <hare@...e.de>,
	Richard Sharpe <realrichardsharpe@...il.com>
Subject: Re: [PATCH 0/17]: New SCSI target framework (SCST) with dev handlers
 and 2 target drivers

On Wed, Sep 15, 2010 at 7:56 AM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
>
> Hi Vladislav,
>
> On Tue, Sep 14, 2010 at 06:36:30PM +0400, Vladislav Bolkhovitin wrote:
> > Hi All,
> >
> > Please review this second iteration of the patch set of the new
> > (although, perhaps, the oldest) SCSI target framework for Linux SCST
> > with a set of dev handlers and 2 target drivers: for local access
> > (scst_local) and for Infiniband SRP (srpt).
> >
>
> [ ... ]
>
> And too many "naked returns", I believe common style is to only have
> return for non-void functions.

Hello Dmitry,

If there is agreement among kernel maintainers that return statements
at the end of functions that do not return a value should be avoided,
it might be a good idea to let checkpatch complain about such return
statements. Currently checkpatch doesn't complain about such return
statements.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/