linux-kernel - Re: [RFC 15/22] tcm: Add FILEIO subsystem plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Sep 2010 18:18:21 +0200
From:	Fubo Chen <fubo.chen@...il.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Christie <michaelc@...wisc.edu>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	James Bottomley <James.Bottomley@...e.de>,
	Jens Axboe <axboe@...nel.dk>,
	Boaz Harrosh <bharrosh@...asas.com>
Subject: Re: [RFC 15/22] tcm: Add FILEIO subsystem plugin

On Mon, Aug 30, 2010 at 11:22 AM, Nicholas A. Bellinger
<nab@...ux-iscsi.org> wrote:
> From: Nicholas Bellinger <nab@...ux-iscsi.org>
>
> This patch adds the O_SYNC FILEIO subsystem plugin for accessing struct file
> using Linux/VFS struct file_operations.  It also includes WriteCache and FUA
> Write Emulation support to struct file using fs/sync.c/vfs_fsync_range()
>
> Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>
>
> [ ... ]
>
> +static int fd_do_writev(struct fd_request *req, struct se_task *task)
> +{
> +       struct file *fd = req->fd_dev->fd_file;
> +       struct scatterlist *sg = task->task_sg;
> +       struct iovec iov[req->fd_sg_count];

Kernel stack size is 8 KB. On a 64-bit system struct iovec takes 16
bytes. What happens if req->fd_sg_count is large ? Kernel crash ?

Fubo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/