linux-kernel - Re: [PATCH 2/2] PM: Fix potential issue with failing asynchronous suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100920185929.GB29380@suse.de>
Date:	Mon, 20 Sep 2010 11:59:29 -0700
From:	Greg KH <gregkh@...e.de>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>,
	Kevin Hilman <khilman@...prootsystems.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Colin Cross <ccross@...roid.com>
Subject: Re: [PATCH 2/2] PM: Fix potential issue with failing asynchronous
 suspend

On Mon, Sep 20, 2010 at 08:00:44PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> Subject: PM: Fix potential issue with failing asynchronous suspend
> 
> There is a potential issue with the asynchronous suspend code that
> a device driver suspending asynchronously may not notice that it
> should back off.  There are two failing scenarions, (1) when the
> driver is waiting for a driver suspending synchronously to complete
> and that second driver returns error code, in which case async_error
> won't be set and the waiting driver will continue suspending and (2)
> after the driver has called device_pm_wait_for_dev() and the waited
> for driver returns error code, in which case the caller of
> device_pm_wait_for_dev() will not know that there was an error and
> will continue suspending.
> 
> To fix this issue make __device_suspend() set async_error, so
> async_suspend() doesn't need to set it any more, and make
> device_pm_wait_for_dev() return async_error, so that its callers
> can check whether or not they should continue suspending.
> 
> No more changes are necessary, since device_pm_wait_for_dev() in
> not used by any drivers' suspend routines.
> 
> Reported-by: Colin Cross <ccross@...roid.com>
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/