linux-kernel - Re: [PATCH] PM: Fix signed/unsigned warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201009202127.24691.rjw@sisk.pl>
Date:	Mon, 20 Sep 2010 21:27:24 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Kevin Cernekee <cernekee@...il.com>
Cc:	Pavel Machek <pavel@....cz>, linux-pm@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM: Fix signed/unsigned warning

On Monday, September 20, 2010, Kevin Cernekee wrote:
> Seen on MIPS32, gcc 4.4.3, 2.6.36-rc4:
> 
> drivers/base/power/main.c: In function 'dpm_show_time':
> drivers/base/power/main.c:415: warning: comparison of distinct pointer types lacks a cast
> 
> do_div() takes unsigned parameters:
> 
> uint32_t do_div(uint64_t *n, uint32_t base);
> 
> Using an unsigned variable for usecs64 should not cause any problems,
> because calltime >= starttime .
> 
> Signed-off-by: Kevin Cernekee <cernekee@...il.com>

OK, I'm going to apply it.

Thanks,
Rafael


> ---
>  drivers/base/power/main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 276d5a7..db67719 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -407,7 +407,7 @@ static void pm_dev_err(struct device *dev, pm_message_t state, char *info,
>  static void dpm_show_time(ktime_t starttime, pm_message_t state, char *info)
>  {
>  	ktime_t calltime;
> -	s64 usecs64;
> +	u64 usecs64;
>  	int usecs;
>  
>  	calltime = ktime_get();
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/