linux-kernel - Re: [PATCH 2/3] hid: 3m: Convert to MT slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CE1C24FC-7C9A-4940-8141-391A368C59E5@enac.fr>
Date:	Mon, 20 Sep 2010 21:46:32 +0200
From:	Stéphane Chatty <chatty@...c.fr>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] hid: 3m: Convert to MT slots


Le 28 août 10 à 16:29, Henrik Rydberg a écrit :

>  #define MAX_SLOTS		60
> -#define MAX_TRKID		59
> +#define MAX_TRKID		USHRT_MAX
>

Oops, I forgot this one: in the rest of the code, it seems to me that  
you use your knowledge that TRACKINGID cannot be more than 59 (you  
use it to map the tracking ID onto the slot ID). Therefore, why  
change TRKID to a larger value?

Cheers,

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/