linux-kernel - Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C985F88.1010501@msgid.tls.msk.ru>
Date:	Tue, 21 Sep 2010 11:32:24 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Tejun Heo <htejun@...il.com>
CC:	Jeff Garzik <jeff@...zik.org>,
	Pedro Francisco <pedrogfrancisco@...il.com>,
	linux-kernel@...r.kernel.org,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
Subject: Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced
 by libahci split

21.09.2010 11:25, Tejun Heo wrote:
> libata depends on scsi_host_template for module reference counting and
> sht's should be owned by each low level driver.  During libahci split,
> the sht was left with libahci.ko leaving the actual low level drivers
> not reference counted.  This made ahci and ahci_platform always
> unloadable even while they're being actively used.
> 
> Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for
> each low level ahci driver.
> 
> stable: only applicable to 2.6.35.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-by: Michael Tokarev <mjt@....msk.ru>
> Cc: stable@...nel.org
> ---
> Michael, thanks a lot for spotting it and bearing with me.

Um.  All thanks goes to Pedro Francisco please, not to me -
I just verified your patch on my system, it was Pedro who spotted
and reported this.  You may add my

 Tested-Off-By: Michael Tokarev <mjt@....msk.ru>

, but not Reported-by... please ;)

Thanks!

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/