linux-kernel - Re: [PATCH 4/5] ACPI, APEI, Fix error path for memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100921124552.GD18991@one.firstfloor.org>
Date:	Tue, 21 Sep 2010 14:45:52 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 4/5] ACPI, APEI, Fix error path for memory allocation

On Sun, Sep 19, 2010 at 11:00:34AM +0800, Huang Ying wrote:
> @@ -475,7 +479,13 @@ int apei_resources_request(struct apei_resources *resources,
>  		}
>  	}
>  
> -	apei_resources_merge(&apei_resources_all, resources);
> +	rc = apei_resources_merge(&apei_resources_all, resources);
> +	if (rc) {
> +		pr_err(APEI_PFX
> +"Error in APEI internal resource management, there may be inconsistent "
> +"between APEI internal and system resource management.");

Please fix the English. This will wrap in the syslog without \ns no?
Kernel messges should be not wider than 80 characters.

> +	rc = apei_resources_sub(&apei_resources_all, resources);
> +	if (rc)
> +		pr_err(APEI_PFX
> +"Error in APEI internal resource management, there may be inconsistent "
> +"between APEI internal and system resource management.");

Same.

Also instead of Error it would be better just say what is wrong and don't
try to analyze the problem.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/