linux-kernel - Re: [PATCH 5/5] Staging: comedi: fix EXPORT SYMBOL coding style issue in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100920235928.GC8063@kroah.com>
Date:	Mon, 20 Sep 2010 16:59:28 -0700
From:	Greg KH <greg@...ah.com>
To:	Maurice Dawson <mauricedawson2699@...il.com>
Cc:	gregkh@...e.de, arun.thomas@...il.com, stewart_r@...encamel.com,
	u.kleine-koenig@...gutronix.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: fix EXPORT SYMBOL coding style
 issue in ni_labpc.c

On Sun, Sep 19, 2010 at 07:54:30PM +0100, Maurice Dawson wrote:
> This is a patch to the ni_labpc.c file that fixes up, EXPORT SYMBOL(foo) should immediately follow its function/variable
> warnings, found by the checkpatch.pl tool
> 
> Signed-off-by: Maurice Dawson <mauricedawson2699@...il.com>
> ---
>  drivers/staging/comedi/drivers/ni_labpc.c |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
> index 8d120cd..f18a8a7 100644
> --- a/drivers/staging/comedi/drivers/ni_labpc.c
> +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> @@ -24,7 +24,7 @@ Driver: ni_labpc
>  Description: National Instruments Lab-PC (& compatibles)
>  Author: Frank Mori Hess <fmhess@...rs.sourceforge.net>
>  Devices: [National Instruments] Lab-PC-1200 (labpc-1200),
> -	Lab-PC-1200AI (labpc-1200ai), Lab-PC+ (lab-pc+), PCI-1200 (ni_labpc)
> +	Lab-PC-1200AI(labpc-1200ai), Lab-PC + (lab-pc+), PCI-1200 (ni_labpc)
>  Status: works

Why make this change?

>  
>  Tested with lab-pc-1200.  For the older Lab-PC+, not all input ranges
> @@ -48,12 +48,12 @@ comedilib, use the comedi_calibrate program.
>  
>  Configuration options - ISA boards:
>  [0] - I/O port base address
> -[1] - IRQ (optional, required for timed or externally triggered conversions)
> -[2] - DMA channel (optional)
> +[1] - IRQ(optional, required for timed or externally triggered conversions)
> +[2] - DMA channel(optional)

And these?

They have nothing to do with the patch description above, right?

>  
>  Configuration options - PCI boards:
> -[0] - bus (optional)
> -[1] - slot (optional)
> +[0] - bus(optional)
> +[1] - slot(optional)

Same here.

Care to redo this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/