linux-kernel - Re: [PATCH 2/3] hid: 3m: Convert to MT slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C98ED5B.7020408@euromail.se>
Date:	Tue, 21 Sep 2010 19:37:31 +0200
From:	Henrik Rydberg <rydberg@...omail.se>
To:	Stéphane Chatty <chatty@...c.fr>
CC:	Jiri Kosina <jkosina@...e.cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] hid: 3m: Convert to MT slots

On 09/20/2010 10:23 PM, Stéphane Chatty wrote:

> 
> Le 20 sept. 10 à 22:04, Henrik Rydberg a écrit :
>>>
>>> What about this:
>>> +            value = clamp_val(value, 0, MAX_SLOTS - 1);
>>>              if (md->valid) {
>>>                  md->curid = value;
>>>                  md->f[value].touch = md->touch;
>>>
>>> If you had tracking IDs 59, 60 and 61 in the same frame, this would not work
>>> properly would it?
>>
>>
>> That is the slot id being set. The microtouch controller is also using slots
>> internally.
>>
> 
> Oh, right. Once again back to your definition of tracking ID that is not so
> intuitive to me :-) In the end we might end up dealing with three IDs: the
> device's tracking ID, the slot ID, and the Linux tracking ID. Here, the first
> and the second are the same but will they always be? I remember when Stantum
> used to provide us with 16 bit "device tracking IDs"...
> 
> Anyway, I have no more problem with this constant. Just with the vocabulary :-)


In the HID protocol, it is called ContactID... So, Stéphane, are we close to
acking this patch now? :-)

Cheers,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/