linux-kernel - Re: [PATCH] FW_LOADER: fix kconfig dependency warning on HOTPLUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C99359D.9020700@oracle.com>
Date:	Tue, 21 Sep 2010 15:45:49 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Greg KH <greg@...ah.com>
CC:	lkml <linux-kernel@...r.kernel.org>, gregkh@...e.de,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH] FW_LOADER: fix kconfig dependency warning on HOTPLUG

On 09/21/10 15:25, Greg KH wrote:
> On Sat, Sep 18, 2010 at 01:23:08PM -0700, Randy Dunlap wrote:
>>
>> BTW, drivers/base/firmware_class.c should #include <linux/kobject.h>.
> 
> Why, it looks like it builds properly now, right?

Yes, it builds because (apparently) some other header file is causing
<linux/kobject.h> to be sucked in.  That's not how we prefer to have header
files used.

See Documentation/SubmitChecklist, item #1 (from Stephen Rothwell):

1: If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/