linux-kernel - Re: [PATCH]Update-broken-web-addresses-in-the-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinE73z9QV0zriVE3bRtzMifWSGvG36hfvnA9biD@mail.gmail.com>
Date:	Tue, 21 Sep 2010 00:52:02 -0400
From:	Matt Turner <mattst88@...il.com>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	trivial@...nel.org, linux-kernel@...r.kernel.org,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Finn Thain <fthain@...egraphics.com.au>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dimitry Torokhov <dmitry.torokhov@...il.com>,
	Ben Pfaff <blp@...stanford.edu>,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH]Update-broken-web-addresses-in-the-kernel

On Tue, Sep 21, 2010 at 12:18 AM, Justin P. Mattock
<justinmattock@...il.com> wrote:
> Signed-off-by: Matt Turner <mattst88@...il.com>

Yeah... I didn't give my sign off.

[snip]

> diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
> index b9647bb..8da39ce 100644
> --- a/arch/alpha/Kconfig
> +++ b/arch/alpha/Kconfig
> @@ -219,7 +219,7 @@ config ALPHA_LX164
>        bool "LX164"
>        help
>          A technical overview of this board is available at
> -         <http://www.unix-ag.org/Linux-Alpha/Architectures/LX164.html>.
> +         <http://www.alphalinux.org/>.
>
>  config ALPHA_LYNX
>        bool "Lynx"
> @@ -483,7 +483,7 @@ config ALPHA_AVANTI
>        help
>          Avanti AS 200, AS 205, AS 250, AS 255, AS 300, and AS 400-based
>          Alphas. Info at
> -         <http://www.unix-ag.org/Linux-Alpha/Architectures/Avanti.html>.
> +         <http://www.alphalinux.org/>.
>
>  config ALPHA_BROKEN_IRQ_MASK
>        bool
> diff --git a/arch/alpha/kernel/sys_sio.c b/arch/alpha/kernel/sys_sio.c
> index 85b4aea..c5051aa 100644
> --- a/arch/alpha/kernel/sys_sio.c
> +++ b/arch/alpha/kernel/sys_sio.c
> @@ -154,7 +154,7 @@ noname_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
>         * bridge (PIRQ0-PIRQ3).  The table below is based on
>         * information available at:
>         *
> -        *   http://ftp.digital.com/pub/DEC/axppci/ref_interrupts.txt
> +        *  http://web.archive.org/web/*/http://ftp.digital.com/pub/DEC/axppci/ref_interrupts.txt
>         *
>         * I have no information on the Avanti interrupt routing, but
>         * the routing seems to be identical to the Noname except

This change looks harmless. After all, it's changing a comment. But wait.

You're adding a */ into a block comment, thereby prematurely closing
the comment and breaking compilation.

I imagine that any other places you've changed the link to archive.org
has the same problem.

I appreciate the work, but please drop arch/alpha from your patch.
I'll go through and fix those links at the same time as I update a lot
of other Kconfig information.

Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/