linux-kernel - Re: [PATCH] scripts/get_maintainer.pl: fix .mailmap handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285046435.25988.131.camel@Joe-Laptop>
Date:	Mon, 20 Sep 2010 22:20:35 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Mickler <florian@...kler.org>
Cc:	linux-kernel@...r.kernel.org, ebiederm@...ssion.com,
	greg@...ah.com, stefanr@...6.in-berlin.de,
	broonie@...nsource.wolfsonmicro.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCH] scripts/get_maintainer.pl: fix .mailmap handling

On Tue, 2010-09-21 at 06:59 +0200, Florian Mickler wrote:
> Come on, Joe! It was "sub mailmap" before. @addresses was @list before
> and @ret is the list that get's returned by the function. 

Tell me, what's better as an individual line in perl
with typeless returns
	return @ret;
or
	return @list;

@ret is not descriptive.
Yeah, it's an array.
An array of what?
btw: @list was sub-optimal too.

> If you think a patch is ok, you actually may say so. 

As we discussed privately, yes, .mailmap handling was broken
but both of us seem to think that it's not even necessary as
most .mailmap entries are created manually and it's not
up-to-date.  Name de-duplication is more effective.

.mailmap could be used effectively I suppose, but I asked you
to show a use case where it performs differently than the
existing name de-duplication.

And, I do ack a patch after I think it is ready to be applied.
Until then, I note what I see as shortcomings and defects.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/