linux-kernel - Re: [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup monitoring (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100922091834.GJ6676@balbir.in.ibm.com>
Date:	Wed, 22 Sep 2010 14:48:34 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	eranian@...gle.com, linux-kernel@...r.kernel.org, mingo@...e.hu,
	paulus@...ba.org, davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com,
	robert.richter@....com, acme@...hat.com,
	Paul Menage <menage@...gle.com>, Li Zefan <lizf@...fujitsu.com>
Subject: Re: [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup
 monitoring (v3)

* Peter Zijlstra <peterz@...radead.org> [2010-09-22 09:27:59]:

> On Wed, 2010-09-22 at 09:53 +0530, Balbir Singh wrote:
> > Yes, a task can belong to multiple subsystems, hence multiple cgroups.
> > Ideally we'd want to use pid + subsystem
> 
> Apparently we create a perf subsystem, and we only care about that. So
> pid will uniquely identify a cgroup, since for each subsystem a task can
> only belong to one cgroup.

Hmm.. I misread the intention to mean we care about monitoring all
data and aggregate it for each cgroup.

> 
> > > One thing we could do is pass this cgroup identifier in the pid field
> > > and use PERF_FLAG_CGROUP or something. Currently the syscall signature
> > > uses pid_t, but I think we can safely change that to int.
> > 
> > Or union it and overload the field to contain either pid_t or fd of the cgroup
> 
> Its not a field, its an argument.

Thanks!

-- 
	Three Cheers,
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/