linux-kernel - Re: [PATCH] drivers/power: add missing sysfs_remove_group() in pcf50633_mbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100922121658.GA24829@oksana.dev.rtsoft.ru>
Date:	Wed, 22 Sep 2010 16:18:45 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Balaji Rao <balajirrao@...nmoko.org>,
	Paul Fertser <fercerpav@...il.com>
Subject: Re: [PATCH] drivers/power: add missing sysfs_remove_group() in
 pcf50633_mbc_remove()

On Tue, Sep 21, 2010 at 04:35:57PM +0800, Axel Lin wrote:
> sysfs entries should be removed when unload the module.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied, thanks!

> ---
>  drivers/power/pcf50633-charger.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/power/pcf50633-charger.c b/drivers/power/pcf50633-charger.c
> index 066f994..4fa52e1 100644
> --- a/drivers/power/pcf50633-charger.c
> +++ b/drivers/power/pcf50633-charger.c
> @@ -456,6 +456,7 @@ static int __devexit pcf50633_mbc_remove(struct platform_device *pdev)
>  	for (i = 0; i < ARRAY_SIZE(mbc_irq_handlers); i++)
>  		pcf50633_free_irq(mbc->pcf, mbc_irq_handlers[i]);
>  
> +	sysfs_remove_group(&pdev->dev.kobj, &mbc_attr_group);
>  	power_supply_unregister(&mbc->usb);
>  	power_supply_unregister(&mbc->adapter);
>  	power_supply_unregister(&mbc->ac);

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/