linux-kernel - Re: [PATCH] x86/mrst: add SFI platform device parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285169717.4498.121.camel@i7.infradead.org>
Date:	Wed, 22 Sep 2010 16:35:17 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/mrst: add SFI platform device parsing code

On Wed, 2010-09-22 at 16:33 +0100, Mark Brown wrote:
> On Wed, Sep 22, 2010 at 04:22:13PM +0100, David Woodhouse wrote:
> 
> > It makes *no* sense to add probe support for your 'special' platform
> > devices to drivers which already have (or will need anyway) proper
> > device-tree support.
> 
> To be fair they're not doing this, all this code is in the arch code
> rather than the driver code (which is a separate concern).
> 
> > Seriously, just convert whatever crap you have into a device-tree at
> > early boot (or preferably in the bootloader, and *beat* the firmware
> > idiots until they provide it natively), and don't pollute the kernel any
> > more than you have to with this idiocy.
> 
> This is roughly what it's doing except that it's going to native Linux
> bus types and platform data rather than to device tree.

It still means that drivers for chips which are seen both on this
bizarre abomination and also on other machines which use a device-tree
will need to support *both* probe types.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/