linux-kernel - Re: [PATCH 04/14] memstick: core: fix device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285172637.2993.195.camel@mulgrave.site>
Date:	Wed, 22 Sep 2010 11:23:57 -0500
From:	James Bottomley <James.Bottomley@...e.de>
To:	Greg KH <greg@...ah.com>
Cc:	Boaz Harrosh <bharrosh@...asas.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vasiliy Kulikov <segooon@...il.com>,
	kernel-janitors@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Jiri Slaby <jirislaby@...il.com>, linux-kernel@...r.kernel.org,
	Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH 04/14] memstick: core: fix device_register() error
 handling

On Wed, 2010-09-22 at 09:20 -0700, Greg KH wrote:
> > What other email? ... neither you nor Kay replied after either Boaz's
> > patch or the corrected one were posted.
> 
> See my other email a minute ago in response to this thread.

Can we start again?  You've been replying to a patch to do a
put_device() in device_register() which everyone agrees looks wrong.

The proposal to fix all of this is to free the kobject name and NULL it
out in device_add().  That fixes all the places you and kay broke when
you added the variable length name stuff.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/