linux-kernel - Re: [PATCH] perf build fixes for opensuse 10.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100922182053.GA9058@elte.hu>
Date:	Wed, 22 Sep 2010 20:20:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	John Kacur <jkacur@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...hat.com,
	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf build fixes for opensuse 10.0

* John Kacur <jkacur@...hat.com> wrote:

> On Wed, Sep 22, 2010 at 1:15 PM, Andi Kleen <andi@...stfloor.org> wrote:
> >> On Wed, Sep 22, 2010 at 11:03 AM, Andi Kleen <andi@...stfloor.org> wrote:
> >>> Fix the perf Makefile to compile on opensuse 10.0
> >>>
> >>> -Werror in shipping code is usually a bad idea. Remove that.
> >>
> >> Why not remove it then when you ship the code, but leave it in the kernel
> >> where it is useful?
> >
> > What do you mean with "you ship"?
> 
> The subject of your email is "perf build fixes for opensuse 10.0"
> So, I inferred from there.
> 
> > I downloaded a kernel from kernel.org, it shipped to me and didn't
> > build.
> 
> Any reason you can't fix the build errors instead?

Well, it's Andi - he has a well established track record for picking the 
worst possible solution for pretty much anything and then being 
passive-agressive difficult about it as if there was no tomorrow. It's 
typically quite time-consuming for everyone involved, with little 
productive output. YMMV.

Here he could have done a dozen things to make his posting more useful: 
he could have included the build warnings in the changelog (he didnt), 
he could have tried to address them (he didnt), he could have argued for 
some specific warnings to be disabled on specific, well-established 
grounds, for example demonstrating that it _only_ produces false 
positives (he didnt) - etc. etc. He did none of those things.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/