linux-kernel - Re: [Patch, RFC] Make struct fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Sep 2010 21:35:41 +0200
From:	Bruno Prémont <bonbons@...ux-vserver.org>
To:	James Simmons <jsimmons@...radead.org>
Cc:	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Bernie Thompson <bernie@...gable.com>
Subject: Re: [Patch, RFC] Make struct fb_info ref-counted with kref

On Wed, 22 September 2010 James Simmons <jsimmons@...radead.org> wrote:
> > > I have a tree at
> > > 
> > > http://git.infradead.org/users/jsimmons/linuxconsole-2.6.git
> > > 
> > > but currently fbcon is broken so I'm tracing down the problem.
> > 
> > Thanks for the reference to your tree!
> > 
> > What's you opinion regarding my changes to fbcon in my RFC patch?
> > Are they ok or would you prefer having fbcon changed to stop peeking
> > at registered_fb list and just operate directly on fb_info everywhere
> > it needs it? (that is let con2fb_map[] point to fb_info instead of
> > indexes into registered_fb? (I have a preference for the second one
> > and will try it out)
> 
> I'm aiming to kill off registered_fb. I agree that fb_info should be used 
> directly and we can avoid the ref-count. As for con2fb_map that is a 
> little more complex. 

Refcounting can't be fully avoided on fb side but certainly can be on
(most of) fbcon side (except around fbcon's calls to fbops.fb_open and
fbops.fb_release).

Will attempt the fbcon change as a separate patch my ref-counted fb_info
patch will depend on. (will probably happen during week-end)

Thanks,
Bruno
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/