linux-kernel - Re: [PATCH 2/2] TTY: create tty/vt and move the vt code there

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Sep 2010 11:10:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Greg KH <greg@...ah.com>
Cc:	Greg KH <gregkh@...e.de>, Jiri Slaby <jslaby@...e.cz>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org,
	Rogier Wolff <R.E.Wolff@...wizard.nl>,
	"Michael H. Warfield" <mhw@...tsend.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH 2/2] TTY: create tty/vt and move the vt code there

On Wednesday 22 September 2010, Greg KH wrote:
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile
> index c999eac..acd1710 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -12,10 +12,8 @@ obj-y         += mem.o random.o
>  obj-$(CONFIG_LEGACY_PTYS)      += pty.o
>  obj-$(CONFIG_UNIX98_PTYS)      += pty.o
>  obj-y                          += misc.o
> -obj-$(CONFIG_VT)               += vt_ioctl.o vc_screen.o selection.o keyboard.o
>  obj-$(CONFIG_BFIN_JTAG_COMM)   += bfin_jtag_comm.o
>  obj-$(CONFIG_CONSOLE_TRANSLATIONS) += consolemap.o consolemap_deftbl.o
> -obj-$(CONFIG_HW_CONSOLE)       += vt.o defkeymap.o
>  obj-$(CONFIG_MAGIC_SYSRQ)      += sysrq.o
>  obj-$(CONFIG_MVME147_SCC)      += generic_serial.o vme_scc.o
>  obj-$(CONFIG_MVME162_SCC)      += generic_serial.o vme_scc.o
> @@ -114,7 +112,7 @@ obj-$(CONFIG_JS_RTC)                += js-rtc.o
>  js-rtc-y = rtc.o
>  
>  # Files generated that shall be removed upon make clean
> -clean-files := consolemap_deftbl.c defkeymap.c
> +clean-files := consolemap_deftbl.c

IMHO the CONFIG_CONSOLE_TRANSLATIONS stuff belongs in the same directory
as the VT driver, because it is only used in VT. It also puts all teh
unusual Makefile bits into one place.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/