| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2010 17:06:34 +0800 From: huang ying <huang.ying.caritas@...il.com> To: Andi Kleen <andi@...stfloor.org> Cc: Huang Ying <ying.huang@...el.com>, Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, Jin Dongming <jin.dongming@...css.fujitsu.com> Subject: Re: [PATCH 3/5] ACPI, APEI, HEST Fix the unsuitable usage of platform_data Hi, Andi, On Tue, Sep 21, 2010 at 8:43 PM, Andi Kleen <andi@...stfloor.org> wrote: > On Sun, Sep 19, 2010 at 11:00:33AM +0800, Huang Ying wrote: >> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c >> index 343168d..1a3508a 100644 >> --- a/drivers/acpi/apei/hest.c >> +++ b/drivers/acpi/apei/hest.c >> @@ -137,20 +137,23 @@ static int hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void *data) >> >> static int hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data) > > hest_hdr is a local variable on the stack. > > >> + >> + rc = platform_device_add_data(ghes_dev, &hest_hdr, sizeof(void *)); >> + if (rc) >> + goto err; > > Now you put the address of that local variable in some global data structure. > > And then you likely return and later the access accesses random stack space? platform_device_add_data will allocate some new memory, and copy hest_hdr to there, so this is safe. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists