linux-kernel - Re: [PATCH 12/20] powerpc: change to new flag variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Sep 2010 20:19:23 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	matt mooney <mfm@...eddisk.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	kernel-janitors@...r.kernel.org, Alexander Graf <agraf@...e.de>,
	linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Avi Kivity <avi@...hat.com>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 12/20] powerpc: change to new flag variables

Hi Matt,

On Wed, 22 Sep 2010 23:51:09 -0700 matt mooney <mfm@...eddisk.com> wrote:
>
> Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.

This looks good.  One comment below ...

> --- a/arch/powerpc/platforms/pseries/Makefile
> +++ b/arch/powerpc/platforms/pseries/Makefile
> @@ -1,10 +1,5 @@
> -ifeq ($(CONFIG_PPC64),y)
> -EXTRA_CFLAGS		+= -mno-minimal-toc
> -endif
> -
> -ifeq ($(CONFIG_PPC_PSERIES_DEBUG),y)
> -EXTRA_CFLAGS		+= -DDEBUG
> -endif
> +ccflags-$(CONFIG_PPC64)			:= -mno-minimal-toc
> +ccflags-$(CONFIG_PPC_PSERIES_DEBUG)	+= -DDEBUG
>  
>  obj-y			:= lpar.o hvCall.o nvram.o reconfig.o \
>  			   setup.o iommu.o event_sources.o ras.o \
> @@ -23,7 +18,7 @@ obj-$(CONFIG_MEMORY_HOTPLUG)	+= hotplug-memory.o
>  obj-$(CONFIG_HVC_CONSOLE)	+= hvconsole.o
>  obj-$(CONFIG_HVCS)		+= hvcserver.o
>  obj-$(CONFIG_HCALL_STATS)	+= hvCall_inst.o
> -obj-$(CONFIG_PHYP_DUMP)	+= phyp_dump.o
> +obj-$(CONFIG_PHYP_DUMP)		+= phyp_dump.o
>  obj-$(CONFIG_CMM)		+= cmm.o
>  obj-$(CONFIG_DTL)		+= dtl.o

This looks like a spurious extra hunk.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped