linux-kernel - Re: [PATCH 01/13] drivers/gpu/drm: Remove unnecessary casts of private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1009231335470.26813@pobox.suse.cz>
Date:	Thu, 23 Sep 2010 13:36:04 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/13] drivers/gpu/drm: Remove unnecessary casts of
 private_data

On Sat, 4 Sep 2010, Joe Perches wrote:

> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c      |    2 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c     |    2 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 84c53e4..a823d8f 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -631,7 +631,7 @@ int radeon_mmap(struct file *filp, struct vm_area_struct *vma)
>  		return drm_mmap(filp, vma);
>  	}
>  
> -	file_priv = (struct drm_file *)filp->private_data;
> +	file_priv = filp->private_data;
>  	rdev = file_priv->minor->dev->dev_private;
>  	if (rdev == NULL) {
>  		return -EINVAL;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> index e6a1eb7..dc043c3 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
> @@ -542,7 +542,7 @@ int vmw_fifo_mmap(struct file *filp, struct vm_area_struct *vma)
>  	struct drm_file *file_priv;
>  	struct vmw_private *dev_priv;
>  
> -	file_priv = (struct drm_file *)filp->private_data;
> +	file_priv = filp->private_data;
>  	dev_priv = vmw_priv(file_priv->minor->dev);
>  
>  	if (vma->vm_pgoff != (dev_priv->mmio_start >> PAGE_SHIFT) ||
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
> index 8312328..1e8eedd 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
> @@ -39,7 +39,7 @@ int vmw_mmap(struct file *filp, struct vm_area_struct *vma)
>  		return drm_mmap(filp, vma);
>  	}
>  
> -	file_priv = (struct drm_file *)filp->private_data;
> +	file_priv = filp->private_data;
>  	dev_priv = vmw_priv(file_priv->minor->dev);
>  	return ttm_bo_mmap(filp, vma, &dev_priv->bdev);
>  }

This patch isn't present in linux-next as of today. Taking through trivial 
queue.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/