linux-kernel - Re: [PATCH 05/13] drivers/scsi: Remove unnecessary casts of private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1009231344150.26813@pobox.suse.cz>
Date:	Thu, 23 Sep 2010 13:45:13 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Adaptec OEM Raid Solutions <aacraid@...ptec.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Doug Gilbert <dgilbert@...erlog.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/13] drivers/scsi: Remove unnecessary casts of
 private_data

On Sat, 4 Sep 2010, Joe Perches wrote:

> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/scsi/aacraid/linit.c |    2 +-
>  drivers/scsi/sg.c            |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> index cad6f9a..aa40036 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -770,7 +770,7 @@ static long aac_compat_cfg_ioctl(struct file *file, unsigned cmd, unsigned long
>  {
>  	if (!capable(CAP_SYS_RAWIO))
>  		return -EPERM;
> -	return aac_compat_do_ioctl((struct aac_dev *)file->private_data, cmd, arg);
> +	return aac_compat_do_ioctl(file->private_data, cmd, arg);
>  }
>  #endif
>  
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 78d6163..6efa8dd 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -210,7 +210,7 @@ static void sg_put_dev(Sg_device *sdp);
>  
>  static int sg_allow_access(struct file *filp, unsigned char *cmd)
>  {
> -	struct sg_fd *sfp = (struct sg_fd *)filp->private_data;
> +	struct sg_fd *sfp = filp->private_data;
>  
>  	if (sfp->parentdp->device->type == TYPE_SCANNER)
>  		return 0;

This patch isn't present in linux-next as of today. Applying to my tree 
now.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/