linux-kernel - Re: [PATCH] drm/nouveau: fix panels using straps-based mode detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C9BA2DB.8060503@turmel.org>
Date:	Thu, 23 Sep 2010 14:56:27 -0400
From:	Phil Turmel <philip@...mel.org>
To:	Ben Skeggs <skeggsb@...il.com>
CC:	dri-devel@...ts.freedesktop.org, airlied@...hat.com,
	linux-kernel@...r.kernel.org, Ben Skeggs <bskeggs@...hat.com>
Subject: Re: [PATCH] drm/nouveau: fix panels using straps-based mode detection

On 09/23/2010 02:44 AM, Ben Skeggs wrote:
> From: Ben Skeggs <bskeggs@...hat.com>
> 
> nouveau_bios_fp_mode() zeroes the mode struct before filling in relevant
> entries.  This nukes the mode id initialised by drm_mode_create(), and
> causes warnings from idr when we try to remove the mode.
> 
> Signed-off-by: Ben Skeggs <bskeggs@...hat.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_connector.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 98c214c..4b286a8 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -594,8 +594,10 @@ nouveau_connector_get_modes(struct drm_connector *connector)
>  	if (nv_encoder->dcb->type == OUTPUT_LVDS &&
>  	    (nv_encoder->dcb->lvdsconf.use_straps_for_mode ||
>  	     dev_priv->vbios.fp_no_ddc) && nouveau_bios_fp_mode(dev, NULL)) {
> -		nv_connector->native_mode = drm_mode_create(dev);
> -		nouveau_bios_fp_mode(dev, nv_connector->native_mode);
> +		struct drm_display_mode mode;
> +
> +		nouveau_bios_fp_mode(dev, &mode);
> +		nv_connector->native_mode = drm_mode_duplicate(dev, &mode);
>  	}
>  
>  	/* Find the native mode if this is a digital panel, if we didn't

I had this same problem, and this patch fixes it.  Feel free to add:

Tested-by: Philip J. Turmel <philip@...mel.org>

Regards,

Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/