linux-kernel - RE: [PATCH 1/1] Rename camel case variables in channel.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1FB5E1D5CA062146B38059374562DF7289ED3968@TK5EX14MBXC130.redmond.corp.microsoft.com>
Date:	Thu, 23 Sep 2010 21:04:02 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Joe Perches <joe@...ches.com>
CC:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'devel@...verdev.osuosl.org'" <devel@...verdev.osuosl.org>,
	"'virtualization@...ts.osdl.org'" <virtualization@...ts.osdl.org>,
	"'gregkh@...e.de'" <gregkh@...e.de>,
	Hank Janssen <hjanssen@...rosoft.com>
Subject: RE: [PATCH 1/1] Rename camel case variables in channel.c

> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Thursday, September 23, 2010 4:41 PM
> > -	struct hv_monitor_page *monitorPage;
> > +	struct hv_monitor_page *monitorpage;
> 
> Some of these renames would be better with a "_" for
> the CamelCase conversions (ie: CamelCase -> camel_case).

Yes, for longer names I usually insert underscore. For example, 
I changed packetLenAligned to packetlen_aligned.

> > +	struct hv_monitor_page *monitorpage;
> > +	u8 monitorGroup = (u8)channel->OfferMsg.MonitorId / 32;
> > +	u8 monitorOffset = (u8)channel->OfferMsg.MonitorId % 32;
> 
> Why not convert these to monitor_(group|offset)?

That's a good catch. I will update it.

Thanks,

- Haiyang