linux-kernel - Re: [PATCH] floppy: switch to one queue per drive instead of sharing a queue (Was: Re: cgq vs bdi names, was "cfq-iosched: fix a kernel OOPs when usb key is inserted")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Sep 2010 17:40:15 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	Christoph Hellwig <hch@....de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Maxim Levitsky <maximlevitsky@...il.com>
Subject: Re: [PATCH] floppy: switch to one queue per drive instead of sharing
 a queue (Was: Re: cgq vs bdi names, was "cfq-iosched: fix a kernel OOPs when
 usb key  is inserted")

On Thu, Sep 23, 2010 at 09:59:11AM +0200, Jens Axboe wrote:
> On 2010-09-22 22:42, Vivek Goyal wrote:
> > On Wed, Sep 22, 2010 at 12:17:54AM +0200, Jens Axboe wrote:
> > 
> > [..]
> >> Super, thanks a lot! I will queue this up. If you want to continue
> >> this (very noble) crusade, the next target is
> >> drivers/mtd/mtd_blkdevs.c. I never got that one started, but it was
> >> next on my list.
> > 
> > Hi Jens,
> > 
> > IIUC, for MTD this conversion is already done and we seem to be using separate
> > request queue for each gendisk instead of some disks sharing a single
> > request queue. I think by following is relevant commit. Maxim should be
> > able to confirm though.
> 
> Great! So the question is if other drivers with shared queues remain.
> 

I was browsing through drivers/blcok/ dir and apart from amiga and atari
floppy drivers, following also seems to be sharing the request queue across
gendisks.

drivers/block/cpqarray.c
drivers/block/hd.c
drivers/block/swim3.c
drivers/block/swim.c
drivers/block/xd.c

I will look into fixing those, the biggest challenge in front of me is
testing the changes. Especially arch specific drivers.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/