linux-kernel - Re: pata_it821x driver reports many FLUSH CACHE command failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100924004343.0abebfad@lxorguk.ukuu.org.uk>
Date:	Fri, 24 Sep 2010 00:43:43 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: pata_it821x driver reports many FLUSH CACHE command failures

On Thu, 23 Sep 2010 17:27:24 -0400
Chuck Ebbert <cebbert@...hat.com> wrote:

> It looks like pata_it821x has never supported FLUSH_CACHE, but now

That depends on the firmware you have I believe

The ident it provides also doesn't advertise flush cache so something
appears to be issuing a cache flush despite the drive reporting that it
is not supported.

> we're seeing repeated failures. They happen over and over again and
> prevent installation. I stuck a dump_stack() in the failure path and
> got this:

Yes you'll crash some firmware versions if this occurs.

See:

static unsigned int it821x_read_id(struct ata_device *adev,
                                        struct ata_taskfile *tf, u16 *id)

If this has stopped working then you probably want to get Jeff to trace
back into the ATA and SCSI midlayer to see why it is issuing flushes for
a device which is reporting that cache flush is not supported - because
that is seriously broken.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/