linux-kernel - Re: mmotm 2010-09-22 - build error in drivers/staging/zram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100923042134.GA29818@kroah.com>
Date:	Wed, 22 Sep 2010 21:21:34 -0700
From:	Greg KH <greg@...ah.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Valdis.Kletnieks@...edu, Anton Blanchard <anton@...ba.org>,
	linux-kernel@...r.kernel.org
Subject: Re: mmotm 2010-09-22 - build error in drivers/staging/zram

On Wed, Sep 22, 2010 at 08:43:05PM -0700, Andrew Morton wrote:
> On Wed, 22 Sep 2010 23:26:06 -0400 Valdis.Kletnieks@...edu wrote:
> 
> > On Wed, 22 Sep 2010 16:12:09 PDT, akpm@...ux-foundation.org said:
> > > The mm-of-the-moment snapshot 2010-09-22-16-11 has been uploaded to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > Looks like zram-free-percpu-data-on-module-exit.patch has issues:
> > 
> >   CC [M]  drivers/staging/zram/zram_drv.o
> > drivers/staging/zram/zram_drv.c: In function 'zram_reset_device':
> > drivers/staging/zram/zram_drv.c:500:2: error: incompatible type for argument 1 of 'free_percpu'
> > include/linux/percpu.h:153:13: note: expected 'void *' but argument is of type 'struct zram_stats'
> > make[3]: *** [drivers/staging/zram/zram_drv.o] Error 1
> > 
> 
> bah.  `make allmodconfig' enables CONFIG_STAGING_EXCLUDE_BUILD, so
> nothing under staging gets built.  Seems rather dumb.

That was done on purpose :)

> zram-free-percpu-data-on-module-exit.patch seems to be unneeded in the
> current zram driver - I'll drop the patch, thanks.

I'm waiting to see it all be hashed out, feel free to drop it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/