linux-kernel - Re: [PATCH] Convert preempt_disabled in module.c to rcu read lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201009231037.09417.rusty@rustcorp.com.au>
Date:	Thu, 23 Sep 2010 10:37:08 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	paulmck@...ux.vnet.ibm.com, tglx@...utronix.de
Subject: Re: [PATCH] Convert preempt_disabled in module.c to rcu read lock

On Wed, 22 Sep 2010 10:37:20 pm Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Thomas Gleixner pointed out that the list_for_each_rcu()
> in module really need to use RCU read lock, not preempt disable.
> This is especially needed for the preemptive RCU code.
> >From what I understand the only reason for the preemption
> disabling is to protect against rcu, so using rcu_read_lock()
> is correct.

The preempt_disable() also protects against stop_machine() on
module remove.

I haven't been following the RCU story, but we were always slightly
abusing the infrastructure here just to do lockless insert.  If
list_for_each_entry_rcu() is changing, perhaps we need to open-code
the old version here?

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/