linux-kernel - [PATCH] some clean up to intel-gtt.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4C9CB4DA0200007800018CFE@vpn.id2.novell.com>
Date:	Fri, 24 Sep 2010 13:25:30 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<chris@...is-wilson.co.uk>
Cc:	<eric@...olt.net>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] some clean up to intel-gtt.c

In commit e517a5e97080bbe52857bd0d7df9b66602d53c4d the call to
map_page_into_agp() got removed from intel_i830_setup_flush(), but the
counterpart call from intel_i830_fini_flush() to unmap_page_from_agp()
was left in place.

Additionally, the page allocated here never gets its physical address
used for sending to hardware, so there's no need to allocate it with
GFP_DMA32. Nor is __GFP_ZERO really necessary, as the page is used
only to store data to force flushing of some internal processor state.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>
Cc: Eric Anholt <eric@...olt.net>

---
 drivers/char/agp/intel-gtt.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.36-rc5/drivers/char/agp/intel-gtt.c
+++ 2.6.36-rc5-intel-agp-cleanup/drivers/char/agp/intel-gtt.c
@@ -768,7 +768,6 @@ static void intel_i830_fini_flush(void)
 {
 	kunmap(intel_private.i8xx_page);
 	intel_private.i8xx_flush_page = NULL;
-	unmap_page_from_agp(intel_private.i8xx_page);
 
 	__free_page(intel_private.i8xx_page);
 	intel_private.i8xx_page = NULL;
@@ -780,7 +779,7 @@ static void intel_i830_setup_flush(void)
 	if (intel_private.i8xx_page)
 		return;
 
-	intel_private.i8xx_page = alloc_page(GFP_KERNEL | __GFP_ZERO | GFP_DMA32);
+	intel_private.i8xx_page = alloc_page(GFP_KERNEL);
 	if (!intel_private.i8xx_page)
 		return;
 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/