linux-kernel - Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100924100735.47b49580@udp111988uds.am.freescale.net>
Date:	Fri, 24 Sep 2010 10:07:35 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	christophe leroy <christophe.leroy@....fr>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net,
	Anton Vorontsov <avorontsov@...mvista.com>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in
 Device Tree

On Fri, 24 Sep 2010 01:10:06 -0600
Grant Likely <grant.likely@...retlab.ca> wrote:

> On Thu, Sep 16, 2010 at 09:05:03AM +0200, christophe leroy wrote:
> > This patch applies to 2.6.34.7 and 2.6.35.4
> > It fixes an issue during the probe for CPM1 with definition of parameter ram from DTS
> > 
> > Signed-off-by: christophe leroy <christophe.leroy@....fr>
> 
> I'm sorry, I don't understand the fix from the given description.
> What is the problem, and why is cpm_muram_alloc_fixed() the wrong
> thing to call on CPM1?  Does CPM2 still need it?

I don't see how cpm_muram_alloc_fixed() can be used safely at all.  If
you need a fixed address, it shouldn't be part of the general
allocation pool, or something else might get it first.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/