linux-kernel - Re: [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <loom.20100924T063847-735@post.gmane.org>
Date:	Fri, 24 Sep 2010 04:43:34 +0000 (UTC)
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/hwmon: fix module init for	 hotplug-but-no-device-found case

Jan Beulich <JBeulich <at> novell.com> writes:

> 
> In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to
> platform_driver_unregister() was made conditional upon !HOTPLUG_CPU,
> but the return value from coretemp_init() was left to indicate an
> error. This isn't correct, as the negative return value indicates to
> the module loader that initialization failed, which isn't intended
> here and results in dangling pointers.
> 
> Signed-off-by: Jan Beulich <jbeulich <at> novell.com>
> Cc: Chen Gong <gong.chen <at> linux.intel.com>
> 
I have not seen an Acked-by or Nacked-by for this patch or any other patch from
this series from Jan. 

Discussions indicate that the patches are ok. Unless I hear an explicit Nack,
I'll review the patches and apply them if I think they make sense.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/