linux-kernel - Re: [PATCH] x86/hwmon: don't leak device attribute file from pkgtemp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Sep 2010 05:02:28 +0000 (UTC)
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/hwmon: don't leak device attribute file from	pkgtemp_probe()

Jan Beulich <JBeulich <at> novell.com> writes:
> 
> While apparently inherited from coretemp source, this particular error
> handling cleanup path wasn't copied properly (or perhaps got discarded
> intermediately and not re-added properly later).
> 
> Signed-off-by: Jan Beulich <jbeulich <at> novell.com>
> Cc: Fenghua Yu <fenghua.yu <at> intel.com>
> 
> ---
[...]

>  exit_class:
>  	sysfs_remove_group(&pdev->dev.kobj, &pkgtemp_group);
> +exit_dev:
> +	device_remove_file(&pdev->dev, &sensor_dev_attr_temp1_max.dev_attr);
>  exit_free:
>  	kfree(data);
>  exit:
> 
The device file should also be deleted in pkgtemp_remove(). Looks like that got
lost as well.

No need to resend; I'll add that myself.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/