[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTin1YfwwVcDNUBsi34iYC6HA5Y6+uOFZN=+Q2hqs@mail.gmail.com>
Date: Fri, 24 Sep 2010 16:39:20 -0400
From: T Dent <tdent48227@...il.com>
To: matt mooney <mfmooney@...il.com>
Cc: greg@...ah.com, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines
On 9/24/10, matt mooney <mfmooney@...il.com> wrote:
> On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@...il.com> wrote:
>> I changed every makefile in the staging directory to use the proper
>> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) .
>
> Um, you didn't do a lot of these right. Maybe you should look into why
> the change was made in the first place. For semantic reasons, I was
> also changing the first assignment to ":=" from "+=".
I can resend them with the a small modification to the patch files if you want.
>
> Thanks,
> mfm
>
> --
> GPG-Key: 9AFE00EA
>
Thanks,
Tracey Dent
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists