linux-kernel - Re: [usb-storage] [PATCH 23/24] usb: change to new flag variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100924200218.GC25677@one-eyed-alien.net>
Date:	Fri, 24 Sep 2010 13:02:18 -0700
From:	Matthew Dharm <mdharm-kernel@...-eyed-alien.net>
To:	matt mooney <mfm@...eddisk.com>
Cc:	kernel-janitors@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	usb-storage@...ts.one-eyed-alien.net,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Felipe Balbi <felipe.balbi@...ia.com>,
	David Vrabel <david.vrabel@....com>
Subject: Re: [usb-storage] [PATCH 23/24] usb: change to new flag variable

On Fri, Sep 24, 2010 at 12:17:33PM -0700, matt mooney wrote:
> Replace EXTRA_CFLAGS with ccflags-y.

> diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile
> index ef7e5a8..786f086 100644
> --- a/drivers/usb/storage/Makefile
> +++ b/drivers/usb/storage/Makefile
> @@ -5,7 +5,7 @@
>  # Rewritten to use lists instead of if-statements.
>  #
>  
> -EXTRA_CFLAGS	:= -Idrivers/scsi
> +ccflags-y	:= -Idrivers/scsi
>  
>  obj-$(CONFIG_USB_STORAGE)	+= usb-storage.o

I don't really know anything about the new 'ccflags' stuff.. but my
instincts tell me that perhaps that should be
'ccflags-$(CONFIG_USB_STORAGE)' rather than 'ccflags-y'?

Does it make a difference that usb-storage can be built-in or a loadable
module?

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@...-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

I could always suspend a few hundred accounts and watch what happens.
					-- Tanya
User Friendly, 7/31/1998

Content of type "application/pgp-signature" skipped