linux-kernel - Re: [PATCH v3 1/5] Adding LogicPD OMAP3 board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Sep 2010 15:58:19 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Tim Nordell <tim.nordell@...icpd.com>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] Adding LogicPD OMAP3 board support

* Tim Nordell <tim.nordell@...icpd.com> [100924 13:06]:
> Adding support for LogicPD's OMAP 3530 LV SOM and
> OMAP 35x Torpedo board.
> 
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -135,6 +135,24 @@ config MACH_OMAP_LDP
>  	default y
>  	select OMAP_PACKAGE_CBB
>  
> +config MACH_OMAP3530_LV_SOM
> +	bool "OMAP3 Logic 3530 LV SOM board"
> +	depends on ARCH_OMAP3
> +	default y
> +	help
> +	 Support for the LogicPD OMAP3530 SOM Development kit
> +	 for full description please see the products webpage at
> +	 http://www.logicpd.com/products/development-kits/texas-instruments-zoom%E2%84%A2-omap35x-development-kit
> +
> +config MACH_OMAP3_TORPEDO
> +	bool "OMAP3 Logic 35x Torpedo board"
> +	depends on ARCH_OMAP3
> +	default y
> +	help
> +	 Support for the LogicPD OMAP35x Torpedo Development kit
> +	 for full description please see the products webpage at
> +	 http://www.logicpd.com/products/development-kits/zoom-omap35x-torpedo-development-kit
> +

Missing select OMAP_PACKAGE_XXX for both boards?

Also, please add the DEBUG_LL entries to
arch/arm/plat-omap/include/plat/uncompress.h. You can test
that by enabling DEBUG_LL and EARLY_PRINTK and have earlyprintk
in your kernel cmdline.

And please repost the whole series so linux-arm-kernel
list is also Cc'd.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/