linux-kernel - Re: [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot of checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100924063616.GD18432@haskell.muteddisk.com>
Date:	Thu, 23 Sep 2010 23:36:16 -0700
From:	matt mooney <mfm@...eddisk.com>
To:	Greg KH <greg@...ah.com>
Cc:	Tracey Dent <tdent48227@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot of
 checkpatch.pl issues

On 19:22 Wed 22 Sep     , Greg KH wrote:
> On Wed, Sep 22, 2010 at 04:24:58PM -0700, matt mooney wrote:
> > On 21:19 Mon 20 Sep     , Tracey Dent wrote:
> > > Fixed numerous coding style issues
> > > 
> > The subject should be more specific as to what the patch does, such as
> > "Staging: rtl8187se: r8180.h: whitespace cleanup."
> > 
> > And the explanation in the commit should also be more specific. There are
> > plenty of examples if you look through the log. Greg might except them as is,
> > but any future patches should follow the advice mentioned. Next time for a
> > patch of this nature remember to CC kernel-janitors too. 
> 
> Why the janitor list?  Do you really want that to be copied on every
> cleanup patch I get like this?  That would be a _lot_...

Heh, well hopefully not all the patches you receive. But there would have been
feedback sooner on this patch stating something along the lines of what I
said. The list is much lower volume making it is easier for devs doing cleanup,
like myself, to follow, so as to not duplicate our efforts. IMHO anyway.

While I have your attention, I am changing all makefiles to use the newer kbuild
flag variables, such as ccflags-y, asflags-y, and ldflags-y. I have already
completed this for all directories in the kernel except drivers which is
next. The patches are trivial but there are a lot in drivers, so should I break
it down by driver or is subdirectory okay? media/video has 85 instances in
something like 12 different subdirectories, so I am not sure what is
best. Please let me know what is best.

Thanks,
mfm
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/