linux-kernel - RE: [PATCH 2.6.35.4] irq: irq and pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CF9C39F99A89134C9CF9C4CCB68B8DDF25AEA5258E@orsmsx501.amr.corp.intel.com>
Date:	Sat, 25 Sep 2010 08:13:36 -0700
From:	"Heasley, Seth" <seth.heasley@...el.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: RE: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel

>> --- linux-2.6.35.4/drivers/i2c/busses/Kconfig.orig	2010-09-24
>14:59:23.000000000 -0700
>> +++ linux-2.6.35.4/drivers/i2c/busses/Kconfig	2010-09-24
>14:59:42.000000000 -0700
>> @@ -95,7 +95,7 @@
>>  	    ESB2
>>  	    ICH8
>>  	    ICH9
>> -	    Tolapai
>> +	    EP80579
>>  	    ICH10
>>  	    3400/5 Series (PCH)
>
>How did this become "5_3400_SERIES" in the symbol names? Shouldn't it
>be 3400_5_SERIES instead?

The way I did it here is consistent with the approved branding submitted for pci.ids.  So perhaps changing the 3400/5 Series to "5 Series/3400 Series" would make sense.

>
>>  	    Cougar Point (PCH)
>> --- linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c.orig	2010-09-24
>14:57:55.000000000 -0700
>> +++ linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c	2010-09-24
>14:59:13.000000000 -0700
>> @@ -38,7 +38,7 @@
>>    82801G   (ICH7)       0x27da     32     hard     yes     yes
>yes
>>    82801H   (ICH8)       0x283e     32     hard     yes     yes
>yes
>>    82801I   (ICH9)       0x2930     32     hard     yes     yes
>yes
>> -  Tolapai               0x5032     32     hard     yes     yes
>yes
>> +  EP80579               0x5032     32     hard     yes     yes
>yes
>
>Maybe keep "Tolapai" inside parentheses, as people may know the
>platform by that name by now?

That'd be fine with me.

-Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/