| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201009252158.28439.Martin@lichtvoll.de> Date: Sat, 25 Sep 2010 21:58:27 +0200 From: Martin Steigerwald <Martin@...htvoll.de> To: linux-pm@...ts.linux-foundation.org Cc: LKML <linux-kernel@...r.kernel.org>, "TuxOnIce-devel" <tuxonice-devel@...onice.net> Subject: Re: [linux-pm] [PATCH] Hibernate: Implement readahead when resuming Am Samstag 25 September 2010 schrieb Martin Steigerwald: > Hi Nigel and Rafael, > > Am Samstag 25 September 2010 schrieb Nigel Cunningham: > > Add support for submitting reads before they're needed. This greatly > > improves the speed of resuming: > > > > From > > > > PM: Image read at 66 MB/s. > > > > to > > > > PM: Image read at 229 MB/s. > > > > ...and removes the need for the sync_read flag. > > So > > martin@...mbhala:~/Computer/Shambhala/Kernel/2.6.36/tuxonice-head> git > branch -av | grep for-rafael > * for-rafael d4e7490 Hibernate: Implement > readahead when resuming > remotes/origin/for-rafael d4e7490 Hibernate: Implement > readahead when resuming [...] > basically seems to work. [...] > I tried 5 times: > > - one with just kdm started worked nicely and really rather fast! > > - four with a full blown KDE 4.5.1 session with OpenGL compositing > - one seemed to hang prior to reinitializing the Radeon KMS DRM setup > - three other worked just fine > > I do not think that the hang is related to your changes, Nigel. The > kernel remained stuck at the lower initial resolution and didn't seem > to initialize the radeon KMS framebuffers at 1400x1050 properly. I > didn't see this with 2.6.35 and userspace software suspend. I am not so sure anymore. I got another one of these hangs with the 2.6.36-rc5 mentioned above. See IMG_3871.jpg for the exact display were it hung. I was able to switch view with Alt-F1 or something like that. And then got IMG_3873.jpg. But nothing happened anymore. Find these on: http://martin-steigerwald.de/tmp/tuxonice/hang-after-resume-with-pm- patches-for-rafael/ I now tried in kernel suspend to disk with martin@...mbhala:~> cat /proc/version Linux version 2.6.35.5-tp42-vmembase-0-pm-avoid-oom-dirty (martin@...mbhala) (gcc version 4.4.5 20100728 (prerelease) (Debian 4.4.4-8) ) #4 PREEMPT Sat Sep 25 13:29:53 CEST 2010 which doesn't contain your patches, Nigel, for about 5 or 6 times and I did not see that hang. So maybe something in your patches, even if just the debug output I mentioned, or something in 2.6.36-rc5 triggers that hang. I will test 2.6.35.5 for a bit longer to make sure that there is no hang on resume prior to loading. I need to reboot this one now too, cause after one of the resume attempts USB stopped working with: Sep 25 21:36:47 shambhala kernel: usb 1-3: New USB device found, idVendor=1307, idProduct=0330 Sep 25 21:36:47 shambhala kernel: usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3 Sep 25 21:36:47 shambhala kernel: usb 1-3: Product: Mass Storage Device Sep 25 21:36:47 shambhala kernel: usb 1-3: Manufacturer: Generic Sep 25 21:36:47 shambhala kernel: usb 1-3: SerialNumber: 00000000000006 Sep 25 21:36:47 shambhala kernel: scsi3 : usb-storage 1-3:1.0 Sep 25 21:36:48 shambhala kernel: BUG: unable to handle kernel NULL pointer dereference at 0000002c Sep 25 21:36:48 shambhala kernel: IP: [<c125b5de>] cfq_get_queue+0x33e/0x550 Sep 25 21:36:48 shambhala kernel: *pde = 00000000 Sep 25 21:36:48 shambhala kernel: Oops: 0000 [#1] PREEMPT Sep 25 21:36:48 shambhala kernel: last sysfs file: /sys/devices/pci0000:00/0000:00:1d.7/usb1/1-3/usb_device/usbdev1 .4/uevent Sep 25 21:36:48 shambhala kernel: Modules linked in: microcode cn acpi_cpufreq mperf ppdev lp vboxnetadp cpufreq_us erspace cpufreq_stats cpufreq_conservative cpufreq_powersave vboxnetflt vboxdrv fuse tun usblp ohci_hcd usb_storage usb_libusual nls_iso8859_15 nls_iso8859_1 nls_cp850 ntfs vfat msdos fat reiserfs isofs udf crc_itu_t smbfs pktcdvd uinput radeon ttm drm_kms_helper drm i2c_algo_bit hdaps tp_smapi thinkpad_ec binfmt_misc dm_crypt snd_intel8x0m sn d_intel8x0 snd_ac97_codec ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm ipw2200 snd_seq_dummy snd_seq_oss thinkpad_acp i hwmon snd_seq_midi libipw led_class snd_rawmidi rtc_cmos pcmcia intel_agp snd_seq_midi_event rtc_core nvram video processor i2c_i801 parport_pc rtc_lib parport ac snd_seq battery button yenta_socket pcmcia_rsrc pcmcia_core joyde v output evdev agpgart snd_timer snd_seq_device snd snd_page_alloc cfg80211 rfkill lib80211 ipv6 autofs4 dm_mod rai d10 raid456 async_pq async_xor xor async_memcpy async_raid6_recov raid6_pq async_tx raid1 raid0 linear md_mod Sep 25 21:36:48 shambhala kernel: btrfs zlib_deflate crc32c libcrc32c usbhid uhci_hcd ehci_hcd sg usbcore sr_mod th ermal cdrom [last unloaded: scsi_wait_scan] Sep 25 21:36:48 shambhala kernel: Sep 25 21:36:48 shambhala kernel: Pid: 10474, comm: scsi_scan_3 Not tainted 2.6.35.5-tp42-vmembase-0-pm-avoid-oom-d irty #4 2373CXG/2373CXG Sep 25 21:36:48 shambhala kernel: EIP: 0060:[<c125b5de>] EFLAGS: 00010086 CPU: 0 Sep 25 21:36:48 shambhala kernel: EIP is at cfq_get_queue+0x33e/0x550 Sep 25 21:36:48 shambhala kernel: EAX: f4d18a80 EBX: f5c9e000 ECX: 00000001 EDX: 00000000 Sep 25 21:36:48 shambhala kernel: ESI: f5c9e108 EDI: f4976000 EBP: dc889cdc ESP: dc889c64 Sep 25 21:36:48 shambhala kernel: DS: 007b ES: 007b FS: 0000 GS: 00e0 SS: 0068 Sep 25 21:36:48 shambhala kernel: Process scsi_scan_3 (pid: 10474, ti=dc888000 task=ed8c8000 task.ti=dc888000) Sep 25 21:36:48 shambhala kernel: Stack: Sep 25 21:36:48 shambhala kernel: 00000000 dc889c7c c102a154 c1a4bfa0 00008010 00000010 ed8c8000 f5c9e044 Sep 25 21:36:48 shambhala kernel: <0> 00000001 f4976020 f5c9e028 f5c9e0d0 f4976444 01cea7c8 f4d18a80 00000030 Sep 25 21:36:48 shambhala kernel: <0> f49763ac f4759600 f41fbcc0 01000202 000000fc 00000000 00000000 00000003 Sep 25 21:36:48 shambhala kernel: Call Trace: Sep 25 21:36:48 shambhala kernel: [<c102a154>] ? cpuacct_charge+0x44/0x50 Sep 25 21:36:48 shambhala kernel: [<c125b993>] ? cfq_set_request+0x1a3/0x410 Sep 25 21:36:48 shambhala kernel: [<c10a9c43>] ? mempool_alloc_slab+0x13/0x20 Sep 25 21:36:48 shambhala kernel: [<c125b7f0>] ? cfq_set_request+0x0/0x410 Sep 25 21:36:48 shambhala kernel: [<c12463f7>] ? elv_set_request+0x17/0x30 Sep 25 21:36:48 shambhala kernel: [<c124c95c>] ? get_request+0x31c/0x340 Sep 25 21:36:48 shambhala kernel: [<c124c9a2>] ? get_request_wait+0x22/0x1a0 Sep 25 21:36:48 shambhala kernel: [<c12f110a>] ? attribute_container_add_device+0x11a/0x1e0 Sep 25 21:36:48 shambhala kernel: [<c1268d81>] ? kvasprintf+0x41/0x50 Sep 25 21:36:48 shambhala kernel: [<c124cfbb>] ? blk_get_request+0x5b/0x90 Sep 25 21:36:48 shambhala kernel: [<c1308998>] ? scsi_execute+0x28/0x240 Sep 25 21:36:48 shambhala kernel: [<c130a627>] ? scsi_execute_req+0x87/0x160 Sep 25 21:36:48 shambhala kernel: [<c130bb6c>] ? scsi_probe_and_add_lun+0x1ec/0x9f0 Sep 25 21:36:48 shambhala kernel: [<c1268d81>] ? kvasprintf+0x41/0x50 Sep 25 21:36:48 shambhala kernel: [<c12e9b24>] ? trace_kmalloc+0x54/0x90 Sep 25 21:36:48 shambhala kernel: [<c130c7e0>] ? __scsi_scan_target+0xe0/0x580 Sep 25 21:36:48 shambhala kernel: [<c102a154>] ? cpuacct_charge+0x44/0x50 Sep 25 21:36:48 shambhala kernel: [<c102a154>] ? cpuacct_charge+0x44/0x50 Sep 25 21:36:48 shambhala kernel: [<c102e2f5>] ? update_curr+0x1b5/0x290 Sep 25 21:36:48 shambhala kernel: [<c130cd06>] ? scsi_scan_channel+0x86/0xa0 Sep 25 21:36:48 shambhala kernel: [<c130cde9>] ? scsi_scan_host_selected+0xc9/0x120 Sep 25 21:36:48 shambhala kernel: [<c130cec0>] ? do_scan_async+0x0/0x180 Sep 25 21:36:48 shambhala kernel: [<c130cebd>] ? do_scsi_scan_host+0x7d/0x80 Sep 25 21:36:48 shambhala kernel: [<c130ced8>] ? do_scan_async+0x18/0x180 Sep 25 21:36:48 shambhala kernel: [<c13fa837>] ? preempt_schedule+0x37/0x50 Sep 25 21:36:48 shambhala kernel: [<c130cec0>] ? do_scan_async+0x0/0x180 Sep 25 21:36:48 shambhala kernel: [<c10531f4>] ? kthread+0x74/0x80 Sep 25 21:36:48 shambhala kernel: [<c1053180>] ? kthread+0x0/0x80 Sep 25 21:36:48 shambhala kernel: [<c100347e>] ? kernel_thread_helper+0x6/0x10 Sep 25 21:36:48 shambhala kernel: Code: e4 83 45 d8 54 83 7d e4 03 0f 85 ee fe ff ff 8b 03 c7 83 64 02 00 00 01 00 00 00 83 e0 03 09 d8 89 03 8b 45 c0 8b 90 58 01 00 00 <8b> 42 2c 85 c0 74 78 8d 55 ec 89 54 24 0c 8d 55 f0 89 54 24 08 Sep 25 21:36:48 shambhala kernel: EIP: [<c125b5de>] cfq_get_queue+0x33e/0x550 SS:ESP 0068:dc889c64 Sep 25 21:36:48 shambhala kernel: CR2: 000000000000002c Sep 25 21:36:48 shambhala kernel: ---[ end trace eecaeed94ae31965 ]--- Sep 25 21:36:48 shambhala kernel: note: scsi_scan_3[10474] exited with preempt_count 1 Maybe the USB system has an powermanagement related issue that in kernel suspend triggers more easily than userspace software suspend? I didn't see this one before. But well, this is a bug I will report in bugzilla.kernel.org. Ciao, -- Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists