linux-kernel - Re: [PATCH] signal: annotate siglock acquisition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285407727.2478.288.camel@edumazet-laptop>
Date:	Sat, 25 Sep 2010 11:42:07 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signal: annotate siglock acquisition

Le samedi 25 septembre 2010 à 18:21 +0900, Namhyung Kim a écrit :
> lock_task_sighand() conditionally acquires sighand->siglock in case of
> returning non-NULL but unlock_task_sighand() releases it unconditionally.
> This leads sparse to complain about the lock context imbalance. Annotate it
> to make sparse happier.

> @@ -1403,7 +1404,9 @@ int send_sigqueue(struct sigqueue *q, struct task_struct *t, int group)
>  	BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
>  
>  	ret = -1;
> -	if (!likely(lock_task_sighand(t, &flags)))
> +	if (likely(lock_task_sighand(t, &flags)))
> +		__acquire(&t->sighand->siglock);
> +	else
>  		goto ret;
>  
>  	ret = 1; /* the signal is ignored */

making sparse happy is good, but changing a likely clause is not,
unless you meant it ;)

maybe -->

	if (!likely(lock_task_sighand(t, &flags)))
		goto ret;
	else
		__acquire(&t->sighand->siglock);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/