Message-ID: <1285524744.2277.41.camel@morgan.silverblock.net>
Date:	Sun, 26 Sep 2010 14:12:24 -0400
From:	Andy Walls <awalls@...metrocast.net>
To:	Alex Deucher <alexdeucher@...il.com>
Cc:	Jon Smirl <jonsmirl@...il.com>,
	Rafał Miłecki <zajec5@...il.com>,
	Dave Airlie <airlied@...hat.com>,
	Greg Kroah-Hartman <greg@...ah.com>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/sysfs: Provide per connector control of DRM KMS
 polling

On Fri, 2010-09-24 at 15:12 -0400, Alex Deucher wrote:
> On Wed, Sep 22, 2010 at 5:07 PM, Andy Walls <awalls@...metrocast.net> wrote:
> > On Wed, 2010-09-22 at 09:33 -0400, Jon Smirl wrote:
> >> On Wed, Sep 22, 2010 at 1:30 AM, Alex Deucher <alexdeucher@...il.com> wrote:
> >> > On Tue, Sep 21, 2010 at 1:30 PM, Andy Walls <awalls@...metrocast.net> wrote:
> >> >> On Tue, 2010-09-21 at 00:26 -0400, Alex Deucher wrote:
> >> >>> 2010/9/20 Andy Walls <awalls@...metrocast.net>:
> >> >>> > On Mon, 2010-09-20 at 20:29 +0200, Rafał Miłecki wrote:
> >> >>> >> 2010/9/20 Andy Walls <awalls@...metrocast.net>:
> >
> >> >> The real problem to me is that the radeon and drm modules have a single,
> >> >> standard way of dealing with EDID errors.  However, EDID errors can
> >> >> happen due to a number of different causes, some of which are external
> >> >> (i.e. in the LCD or CRT monitor).  Given that, there really is no "right
> >> >> thing" the drivers can do without input from the user on what the policy
> >> >> should be when a bad EDID is detected.
> >>


> The attached patch should fix up your board.  Let me know if it works for you.

That patch suppresses the setup of the HDMI and DVI connectors that
don't exist, so the log spam from polling for EDID's is gone for me.

        [PATCH] drm/radeon/kms: add quirk for MSI K9A2GM motherboard
        
        Board has no digital connectors
        
        Reported-by: Andy Walls <awalls@...metrocast.net>
        Tested-by: Andy Walls <awalls@...metrocast.net>
        Signed-off-by: Alex Deucher <alexdeucher@...il.com>
        Cc: stable@...nel.org


Yes it works for me, but it's what I'd call a "point solution".  There
are still these which appear to be the exact same symptoms (perpetual
EDID log spam) just for different hardware setups:

        https://bugs.freedesktop.org/show_bug.cgi?id=27708
        https://partner-bugzilla.redhat.com/show_bug.cgi?id=610362
        

Here was a broader solution for a particular class of machines (Laptops
with i915 chips with an LVDS with a broken EDID) exhibiting those same
symptoms:

        https://patchwork.kernel.org/patch/83556/

Picking these bugs off one or two at a time, as users report the same
symptoms over an over again, is really a waste of users' time.  Users
wait while their report is queued, a custom kernel patch developed, and
a kernel patch makes it through their distro to them.


On a different subject, with your patch applied, I'm now seeing a new
error message in my log that I have not seen before:

	failed to evaluate ATIF got AE_BAD_PARAMETER

Here's the dmesg from drm:

        [drm] Initialized drm 1.1.0 20060810
        [drm] radeon defaulting to kernel modesetting.
        [drm] radeon kernel modesetting enabled.
        radeon 0000:01:05.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
        [drm] initializing kernel modesetting (RS740 0x1002:0x796E).
        [drm] register mmio base: 0xFE7F0000
        [drm] register mmio size: 65536
        ATOM BIOS: ATI
        radeon 0000:01:05.0: VRAM: 128M 0x78000000 - 0x7FFFFFFF (128M used)
        radeon 0000:01:05.0: GTT: 512M 0x80000000 - 0x9FFFFFFF
        [drm] radeon: irq initialized.
        [drm] Detected VRAM RAM=128M, BAR=128M
        [drm] RAM width 128bits DDR
        [TTM] Zone  kernel: Available graphics memory: 963022 kiB.
        [TTM] Initializing pool allocator.
        [drm] radeon: 128M of VRAM memory ready
        [drm] radeon: 512M of GTT memory ready.
        [drm] GART: num cpu pages 131072, num gpu pages 131072
        [drm] radeon: 1 quad pipes, 1 z pipes initialized.
        [drm] Loading RS690/RS740 Microcode
        [drm] radeon: ring at 0x0000000080000000
        [drm] ring test succeeded in 1 usecs
        [drm] radeon: ib pool ready.
        [drm] ib test succeeded in 0 usecs
        [drm] Enabling audio support
        failed to evaluate ATIF got AE_BAD_PARAMETER
        [drm] Default TV standard: NTSC
        [drm] Radeon Display Connectors
        [drm] Connector 0:
        [drm]   VGA
        [drm]   DDC: 0x7e50 0x7e40 0x7e54 0x7e44 0x7e58 0x7e48 0x7e5c 0x7e4c
        [drm]   Encoders:
        [drm]     CRT1: INTERNAL_KLDSCP_DAC1
        [drm] fb mappable at 0xD8040000
        [drm] vram apper at 0xD8000000
        [drm] size 4325376
        [drm] fb depth is 24
        [drm]    pitch is 5632
        fbcon: radeondrmfb (fb0) is primary device
        Console: switching to colour frame buffer device 170x48
        fb0: radeondrmfb frame buffer device
        drm: registered panic notifier
        Slow work thread pool: Starting up
        Slow work thread pool: Ready
        [drm] Initialized radeon 2.6.0 20080528 for 0000:01:05.0 on minor 0


By inspection of the code, it looks like the handle being passed into
radeon_atif_call() by radeon_acpi_init() may be bad.  I'm not sure why
that would be though.

I won't have time until Thursday to run it down any further.

Regards,
Andy

> Thanks,
> 
> Alex


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists