linux-kernel - Re: 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100926154011.61333ffd.rdunlap@xenotime.net>
Date:	Sun, 26 Sep 2010 15:40:11 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	jbeulich@...ell.com, r.marek@...embler.cz,
	guenter.roeck@...csson.com
Subject: Re: 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit
 declaration of function 'cpu_sibling_mask'

On Sun, 26 Sep 2010 23:17:50 +0200 Thomas Meyer wrote:

> $ make V=2
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh - due to target is PHONY
>   CHK     include/generated/compile.h
>   CC [M]  drivers/hwmon/coretemp.o - due to target missing
> drivers/hwmon/coretemp.c: In function 'coretemp_device_remove':
> drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
> make[2]: *** [drivers/hwmon/coretemp.o] Error 1
> make[1]: *** [drivers/hwmon] Error 2
> make: *** [drivers] Error 2
> 
> above function is not defined on UP.

Patch just posted:

http://lkml.org/lkml/2010/9/26/112


> This commit introduced the error:
> 
> commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
> Author: Jan Beulich <jbeulich@...ell.com>
> Date:   Mon Sep 13 10:23:05 2010 +0000
> 
>     x86/hwmon: register alternate sibling upon CPU removal
>     
>     Just like pkgtemp registers another core of the same package when one
>     gets removed, coretemp should register another hyperthread (if
>     available) in that situation.
>     
>     As pointed out in the patch fixing the respective code in pkgtemp, the
>     list protectng mutex must be dropped before calling
>     coretemp_device_add(), and due to the restructured loop (including an
>     explicit return) the "safe" variant of the list iterator isn't needed
>     anymore.
>     
>     Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>     Cc: Rudolf Marek <r.marek@...embler.cz>
>     Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com>
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/