linux-kernel - Re: [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C9F13FA.9030405@redhat.com>
Date:	Sun, 26 Sep 2010 11:35:54 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-trace-users@...r.kernel.org
Subject: Re: [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate_insn

  On 09/24/2010 05:24 AM, Steven Rostedt wrote:
>   >
> >  Note 2: I get output of the form
> >
> >  ... kvm_emulate_insn:     0:fffff800010527b5: mov $0x0, 0xfffe00b0CAN'T FIND FIELD "guest_rip"
> >
> >  which leads me to believe there is a bug in trace_seq_printf when the input
> >  to %s is "".
>
> I ran this under gdb (nice to do that, where I don't in kernel :-)  And
> it takes me to kvm_emulate_insn_handler() which does the
> trace_seq_printf() fine, but then calls pevent_print_num_field() and
> that passes in "guest_rip" where we get the "CAN'T FIND FIELD" error.
>
> In pevent_print_num_field() it searches for "guest_rip" at the top of
> the function (pevent_find_field()), but the event kvm_emulate_insn does
> not have a "guest_rip" field, then it jumps to the error message.
>
>

Gah, what idiot used copy-paste there?

I'll post a patch to remove that line.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/