linux-kernel - [PATCHv3 0/3] watchdog: add f71862fg support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100926140629.GA2150@kreios.titan>
Date:	Sun, 26 Sep 2010 16:06:29 +0200
From:	Lutz Ballaschke <vegan.grindcore@...glemail.com>
To:	Giel van Schijndel <me@...tis.eu>
Cc:	wim@...ana.be, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCHv3 0/3] watchdog: add f71862fg support

Hi everyone,

this patch adds support for the watchdog included in Fintek f71862fg
Super-I/O chip to the f71808e_wdt driver and adds WDIOC_GETTIMELEFT
ioctl which i found very helpful. 

This patch comes in three parts:
1/3: add f71862fg support
2/3: add WDIOC_GETTIMELEFT ioctl and helper function
3/3: clean up/replace some magic numbers/constants

changelog
---------

PATCHv2:
 * module parameter for WDTRST# pin configuration added
 * checking/printk of WDTRST# pin config 
 * removing int typecast

NOTE: due to an unprobable chain of events (sort of ineffable BOB stuff)
there wasn't posted more than PATCHv2 0/3 - sorry for the confusion.

PATCHv3:
 * pin parameter check and pin configuration moved to helper function
 * cleaned up a little more

Furthermore i was thinking about modifying the WDIOC_GETTIMELEFT
helper function since it simply returns the content of the WDT timer 
register without regarding whether the driver runs in minute-mode or not
(thanks to Giel for pointing that out). This means if the driver is loaded 
with a timeout of >255 seconds (and switches to minute-mode) WDIOC_GETTIMELEFT
ioctl returns minutes instead of seconds and thus doesn't comply with 
watchdog-api (e.g. ioctl returns 6(min) not 360(sec)). It might be 
confusing if one loads the driver with a timeout of let's say 360 seconds 
and gets 6 minutes returned by ioctl. But imho it's not very accurate to
return a value of seconds if the wdt doesn't count in seconds. That might
be even more confusing. This inconsistency on the part of the hardware 
maybe can't get satisfyingly compensated by the driver. So i'd prefer the 
most simple solution.

---------

 drivers/watchdog/f71808e_wdt.c |   78 ++++++++++++++++++++++++++++++++++++---
 1 files changed, 72 insertions(+), 6 deletions(-)

Thanks for help and comments,

Lutz Ballaschke

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/