linux-kernel - Re: [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100927062510.GA17825@elte.hu>
Date:	Mon, 27 Sep 2010 08:25:10 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, Fenghua Yu <fenghua.yu@...el.com>,
	Jean Delvare <khali@...ux-fr.org>
Subject: Re: [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined


* Guenter Roeck <guenter.roeck@...csson.com> wrote:

> Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> a build breakage if CONFIG_SMP is undefined. This patch
> fixes the problem.
> 
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Cc: Jean Delvare <khali@...ux-fr.org>
> Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com>
> 
> ---
>  drivers/hwmon/coretemp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index baa842a..58a3c2d 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
>  		list_del(&p->list);
>  		mutex_unlock(&pdev_list_mutex);
>  		kfree(p);
> +#ifdef CONFIG_SMP
>  		for_each_cpu(i, cpu_sibling_mask(cpu))
>  			if (i != cpu && !coretemp_device_add(i))
>  				break;
> +#endif

Wont this result in an 'unused variable i' compiler warning?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/