linux-kernel - RE: [stable] PROBLEM: [BISECTED] 2.6.35.5 xen domU panics just after the boot [PATCH]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Sep 2010 09:37:17 +0100
From:	James Dingwall <james.dingwall@...ocs.com>
To:	Kyle McMartin <kmcmartin@...hat.com>, Greg KH <greg@...ah.com>
CC:	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>,
	"james@...gwall.me.uk" <james@...gwall.me.uk>
Subject: RE: [stable] PROBLEM: [BISECTED] 2.6.35.5 xen domU panics just
 after the boot [PATCH]

> On Sun, Sep 26, 2010 at 11:13:36PM -0700, Greg KH wrote:
> > > Greg, a spelling mistake cropped into this patch during 2.6.35.5
> that
> > > James here points out. Adding you to CC since it seems to have
> missed
> > > stable 2.6.35.6...
> > >
> > > Was in xen-use-percpu-interrupts-for-ipis-and-virqs.patch.
> >
> > I don't understand, where did the error come from?  Was it in a patch
> I
> > applied, or did I mess up some patch?  Is the same problem upstream,
> and
> > if not, why not?
> 
> It's correct upstream, and wrong in the patches you added to
> stable-queue.git for .32 and .35, no idea how it got introduced. :/
> 
> >
> > And finally, can you send this in a format that I can apply it?
> >
> 
> I'm just the messenger... James, can you send a patch to Greg with your
> signed-off-by and such?
> 
> --Kyle
> 
> > thanks,
> >
> > greg k-h

Hi,

My first contribution so I hope I didn't miss any important steps in formatting the patch and that Outlook keeps it intact...  If it needs any fixing up let me know.

James

Correctly name the irq_chip structure to fix an immediate failure when booting as a xen pv_ops guest with a NULL pointer exception. The missing 'x' was introduced in commit [fb412a178502dc498430723b082a932f797e4763] applied to 2.6.3[25]-stable trees.  The commit to mainline was [aaca49642b92c8a57d3ca5029a5a94019c7af69f] which did not have the problem.

Signed-off-by: James Dingwall <james@...gwall.me.uk>
Reported-by: Paweł Zuzelski <pawelz@...-linux.org>
Tested-by: Paweł Zuzelski <pawelz@...-linux.org>

--- drivers/xen/events.c.orig	2010-09-27 09:10:09.245652829 +0100
+++ drivers/xen/events.c	2010-09-27 09:10:27.522304658 +0100
@@ -935,7 +935,7 @@ static struct irq_chip xen_dynamic_chip 
 	.retrigger	= retrigger_dynirq,
 };
 
-static struct irq_chip en_percpu_chip __read_mostly = {
+static struct irq_chip xen_percpu_chip __read_mostly = {
 	.name		= "xen-percpu",
 
 	.disable	= disable_dynirq,

This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement,
you may review at http://www.amdocs.com/email_disclaimer.asp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/