linux-kernel - Re: [PATCH] Update num_symtab, symtab and strtab right after setup of core_num_syms, core_symtab and core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100927085425.GE5785@cr0.nay.redhat.com>
Date:	Mon, 27 Sep 2010 16:54:25 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Hu Tao <hutao@...fujitsu.com>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Update num_symtab, symtab and strtab right after setup
 of core_num_syms, core_symtab and core_strtab.

On Mon, Sep 27, 2010 at 04:22:47PM +0800, Hu Tao wrote:
>On Mon, Sep 27, 2010 at 04:09:54PM +0800, Américo Wang wrote:
>> On Mon, Sep 27, 2010 at 03:30:28PM +0800, Hu Tao wrote:
>> >Signed-off-by: Hu Tao <hutao@...fujitsu.com>
>> 
>> 
>> Changelog is empty.
>> What bug did you observe?
>
>symtab and strtab will point to vfreed memory after free_copy(&info)
>near end of load_module().
>

I think you must mean the error path in load_module(), yeah, probably.

But you need to check if this patch misses other thing, like
the other functions which are called after add_kallsyms() inside load_module().
According to my eyes, this seems fine (at least on x86), so

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

>> 
>> 
>> This patch is not correct, symbols that are not core symbols will be
>> dropped right after this piece of code. So NACK.
>
>There is the reason why we should update num_symtab, symtab and strtab
>before non-core-symbols are dropped.

init section is dropped *after* these value are update, which is correct.

Again, you need to describe what you are trying to fix in your changelog.
Please resend it with a proper changelog.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/