linux-kernel - Re: [PATCH] ubifs: avoid kernel error if ubifs superblock read fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1285577837.16181.14.camel@localhost>
Date:	Mon, 27 Sep 2010 11:57:17 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Steffen Sledz <sledz@...search.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubifs: avoid kernel error if ubifs superblock read
 fails

On Fri, 2010-09-24 at 11:54 +0200, Steffen Sledz wrote:
> * .get_sb is called on mounts with automatic fs detection too, so this
>   function should not print an error if it cannot read the superblock
>   (new behaviour conforms the other fs types)
> 
> Signed-off-by: Steffen Sledz <sledz@...search.de>
> ---
>  fs/ubifs/super.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index cd5900b..e62bb75 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -2049,8 +2049,6 @@ static int ubifs_get_sb(struct file_system_type *fs_type, int flags,
>  	 */
>  	ubi = open_ubi(name, UBI_READONLY);
>  	if (IS_ERR(ubi)) {
> -		ubifs_err("cannot open \"%s\", error %d",
> -			  name, (int)PTR_ERR(ubi));
>  		return PTR_ERR(ubi);
>  	}
>  	ubi_get_volume_info(ubi, &vi);

Hi, could you please instead turn this message into dbg_err() - in this
case we'll have the message only when debugging is enabled.

Also, please CC:

Artem Bityutskiy <dedekind1@...il.com>
linux-mtd@...ts.infradead.org

Thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/