linux-kernel - Re: [PATCH 04/24] hwmon: change to new flag variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12873.1285599840@localhost>
Date:	Mon, 27 Sep 2010 11:04:00 -0400
From:	Valdis.Kletnieks@...edu
To:	matt mooney <mfm@...eddisk.com>
Cc:	kernel-janitors@...r.kernel.org, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/24] hwmon: change to new flag variable

On Fri, 24 Sep 2010 12:17:14 PDT, matt mooney said:
> Replace EXTRA_CFLAGS with ccflags-y.
> 
> Signed-off-by: matt mooney <mfm@...eddisk.com>
> ---
>  drivers/hwmon/Makefile |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index e3c2484..764b4db 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -109,7 +109,5 @@ obj-$(CONFIG_SENSORS_W83L786NG)	+= w83l786ng.o
>  obj-$(CONFIG_SENSORS_WM831X)	+= wm831x-hwmon.o
>  obj-$(CONFIG_SENSORS_WM8350)	+= wm8350-hwmon.o
>  
> -ifeq ($(CONFIG_HWMON_DEBUG_CHIP),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG

Was this series intended as := rather than += as it seems that
overriding the entirely of a passed-in ccflags-y may not be what
we wanted to do.

Content of type "application/pgp-signature" skipped